Skip to content

fix(tools): persist large file outputs before response limits - #7781

Merged
icecrasher321 merged 2 commits into
stagingfrom
codex/fix-large-file-downloads
Sep 11, 2026
Merged

fix(tools): persist large file outputs before response limits#7781
icecrasher321 merged 2 commits into
stagingfrom
codex/fix-large-file-downloads

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Store file bytes before the executor’s 10 MiB JSON admission check, so large downloads return compact UserFile references. Preserve bounded binary transfers and provider-specific limits.
  • Cover internal downloads, external binary endpoints, Jupyter file reads, and late Gmail, Outlook, Teams, and Jira attachment fetches. Share file processing across workflow and Copilot calls, including nested attachment references.
  • Keep new outputs reference-only and remove redundant file metadata aliases. Preserve shipped inline contracts through versioned blocks/tools, and update integration validation skills and generated docs.

Type of Change

  • Bug fix

Testing

  • Regression coverage includes synthetic files over 10 MiB, unchanged JSON limits, aggregate download bounds, cancellation, trusted ownership, rollback, single persistence, nested aliases, and legacy version compatibility.
  • 772 targeted tool/storage/integration tests across 70 files and 96 docs-generator tests pass.
  • App typecheck, full lint, all 46 audit checks, block-registry validation against staging, and docs-manifest validation pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 11, 2026 7:50pm UTC

Request Review

@icecrasher321

icecrasher321 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile @greptile-apps please review this PR, bypassing the automatic 100-file limit. The latest commit completes the attachment coverage and output cleanup.

@icecrasher321

icecrasher321 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable correctness, security, compatibility, or repository-rule issue remains.

Summary

  • Adds bounded storage and rollback handling for workflow and Copilot file outputs.
  • Extends cancellation-aware attachment downloading across Gmail, Jira, Microsoft Teams, and Outlook.
  • Versions integrations whose output contracts remove legacy inline content while retaining old blocks and tools for saved workflows.
  • Aligns block registries, successor authorization mappings, generated tool metadata, integration docs, and deployment catalog entries.
  • Adds regression coverage for size limits, ownership, aliases, cancellation, cleanup, and version compatibility.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Workflow or Copilot tool call] --> B{Tool execution path}
  B -->|External binary response| C[Bounded secure response read]
  B -->|Internal file operation| D[InternalToolFileResult]
  B -->|Late attachment fetch| E[Shared cancellation-aware byte budget]
  C --> F[Trusted file storage scope]
  D --> F
  E --> G[Declared file outputs]
  G --> F
  F --> H[Stored UserFile descriptors]
  H --> I[Replace nested aliases]
  I --> J[Compact JSON tool response]
  F -->|Failure or cancellation| K[Rollback file object and metadata]
Loading

Reviews (1) · Last reviewed commit: "fix(tools): cover late attachments and s..."

@icecrasher321
icecrasher321 merged commit 2217f71 into staging Sep 11, 2026
33 of 34 checks passed
@icecrasher321
icecrasher321 deleted the codex/fix-large-file-downloads branch September 11, 2026 19:54
@waleedlatif1 waleedlatif1 mentioned this pull request Sep 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@icecrasher321